Question

Currently i’m writing a JDBC application to manage a MySQL database. I have the delete, insert and select methods functioning with the correct queries. I’m having trouble with the Update method. When using using the following code I receive a MySQL error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near “”,Street”,Town”,City”,PostCode”,Age”,email”,RunningFee’false’Where PID=” at line 1…

private void updateData()
{
    Connection con;
    try
    {
        Class.forName("com.mysql.jdbc.Driver");
        con = DriverManager.getConnection(
                "jdbc:mysql://localhost/snr","root","");

        String sql = "Update participant Set password='"+txtpassword.getText()+"'," +
                "lastName='"+txtlastName.getText()+"',firstName='"+
                txtfirstName.getText()+"',HouseNumber'"+txtHouseNumber.getText()+"',Street'"+txtStreet.getText()+"',Town'"+txtTown.getText()+"',City'"+txtCity.getText()+"',PostCode'"+txtPostCode.getText()+"',Age'"+txtAge.getText()+"',email'"+txtemail.getText()+"',RunningFee'"+cbRunningFee.isSelected()+"' Where PID='"+txtPID.getText()+"'";

        Statement statement = con.createStatement();

        statement.execute(sql);

        createMessageBox("Updated Successfully");

        clearControls();
    }
    catch(Exception e)
    {
        createMessageBox(e.getMessage());
    }
}

Is there something wrong with my SQL query?

Answer 1

Yes, your query is wrong. You’re missing = on a great big bunch of set column/value pairs.

(And please consider using prepared statements and bind variables, SQL injection is just not something you want to be open to.)