Question

django’s manager docs has a paragraph overwritten with DO NOT FILTER AWAY ANY RESULTS IN THIS TYPE OF MANAGER SUBCLASS, but in the following text only mentions get_query_set()

Is it save to filter in all(), get(), filter(), exclude()?

The reason why I want to do that: I want for the automatic Manager as it gives my the power to control, what rows are send to a template-tag as described in b-list: Write better template tags

Would this code be OK?

class ArticleMananger(models.Manager):
    def get_query_set(self):
        return super(ArticleMananger, self).get_query_set()
    def all(self): 
        return super(ArticleMananger, self).filter(published=True)   
    def filter(self,  **kwargs):
        return super(ArticleMananger, self).filter(published=True).filter(**kwargs) 
    .... 

---

Edit: If someone votes down, it would be nice or just fair to explain why. What is wrong about this question?

Answer 1

I did some test and will answer my own question:

Do not filter in all(),… too!

I just tried it out. It breaks parts of the admin interface. From a technical point of view it could be possible to overwrite / extend template/admin/apps/* to use another manager (ie via own tags), but I come to the conclusion, that it wont worth the work. Instead I will rewrite my tags to something like this:

def render(self, context):
    if hasattr(self.model, 'publicmgr'):
        context[self.varname] = self.model.publicmgr.all().order_by(self.by)[:self.num]
    else:
        context[self.varname] =   self.model._default_manager.all().order_by(self.by)[:self.num]
    return  ''