Question

Does this rankle anyone else out there? I would much rather see:

 block.key(newKey);  // set the key for this block

and

 testKey = block.key();  // look up the key for this block

than

 block.setKey(newKey); // set the key for this block
 testKey = block.getKey(); // look up the key for this block

First, the “set” and “get” are redundant (and hence add noise reducing the readability). The action (set/get) is defined by the syntax of each statement. I understand the overloading. In fact, using the same exact identifier reinforces that these are the same property of the object. When I read “getKey()” and “setKey()” I may not be so sure.

Second, if “get” and “set” are to be strictly interpreted as setter and getter, then if other semantic associated with setting/getting a value, side effects for example, will be surprising.

I suppose this bias comes from my Smalltalk background, but in a world where polymorphism works just fine, wouldn’t we be better off without the “get” and “set” sprinkled everywhere? Just think of how much more code we could type if we didn’t have to type those three letters over and over again?! (tongue somewhat in cheek)

Anyone out there feel the same way?

Answer 1

Prefixing accessors with “get” and mutators with “set” is a practice that varies from language to language, and seems to be mostly prevalent in Java. For example:

• In Python, you have the concept of properties, and so an accessor might look like obj.foo and a mutator might look like obj.foo = bar (even though methods are called behind the scenes). Similar concepts exist in languages such as Ruby. So in a lot of languages, calls to accessors and mutators look like direct “calls” to instance variables, and you never see anything like “setFoo” or “getFoo”.
• Languages such as Objective-C discourage the practice of prefixing accessors with “get”, so in Objective-C you’d see calls like [obj foo] and [obj setFoo:bar].

I never liked the practice of prefixing accessors in Java with “get”, either, but I do see the merit in prefixing mutators with “set”. That said, since the prevailing practice is to prefix with “get”/”set” in Java, I continue the trend in my own code.