Question

Dreamweaver is reporting an error in the 3rd line of the following code:

if (isset($_POST['sitename']))
    {
        $query = "INSERT INTO dllist (name, url, pr) VALUES ( "$_REQUEST['sitename'], $_REQUEST['siteurl'], $_REQUEST['pagerank']" )";
        $result = mysql_query($query) 
            or die("Query Failed".mysql_error());

        echo "<br />Website Has been added<br />";

    }

Also, when running the code in my browser the following error is reported

Parse error: syntax error, unexpected '$_REQUEST' (T_VARIABLE)

Can anybody tell me where the mistake is? I shall really be grateful.

Answer 1

The commas (and the fact your missing the containers around your values (e.g. single quotes)), it should be:

        $query = "INSERT INTO dllist (name, url, pr) VALUES ('".$_REQUEST['sitename']."', '".$_REQUEST['siteurl']."', '".$_REQUEST['pagerank']."')";

Although this is still bad practice, and it has no SQL Injection protection.