Question

echo "<br><font face='Segoe UI' color='blue'><a href='#' onClick='javascript:alert(".$nam.");return false;'>".$nam."</a></font>";

I’d like to know if there’s any syntax error in the above code. I don’t think alert() is being called.

Thanks!

Answer 1

Let us say you have

$nam = 'test';
... your code

This prints out:

'javascript:alert(test); return false;'

That is, it is trying to print out a javascript variable e.g. “test” that was never initialized.

You need to have:

'javascript:alert(\"".$nam."\"); return false;'

Now several recommendations:

Get a good Javascript debugger such as Firefox’s Web Developer toolbar or firebug. You could see the issue immediately.

Don’t use the ‘javascript:’ decleration. It is deprecated and unnecessary.

Use onclick, not onClick.
The font tag is deprecated as are the face and color attributes.
Close your tags (<br /> vs <br>).

Don’t infuse javascript, php, and html. I highly recommend you use a template.

If you are using weak quotes (“, not ‘) php will interpolate variables within the quotes. You don’t have to concatenate. These are equivalent:

echo "javascript:alert('".$nam."');";
echo "javascript:alert('$nam');";