Question

Evening guys,

This may seem like a stupid question but im having some issues figuring out where i should be placing my user input verification checks. I have checks, for the following:

1. file exists
2. Correct extension
3. Access to the file
4. Input in 2 NumericUpDown controls
5. One numericUpDown is always greater than the other.
6. Assignment to static properties.

Im assuming each one of these should at least be a single method but i then have a single method which has a large number of lines which solely check the result of the method calls to the list above. ie

public void VerifyData()
{
    if(VerifyNumber1OnTheList != true)
    {
        LogError("The file specified is incorrect")
        return;
    }

    if(VerifyNumber2OnTheList != ......

Any suggestions on how i should actually be laying this out would be appreciated.

Thanks

Answer 1

Your method above seems like a perfectly fine way of laying out your code.

My only change would be in how you handle your checking. Use well-named methods rather than booleans during your check:

public void VerifyData()
{
    if(FileExists())
    {
        LogError("The file specified is incorrect")
        return;
    }

    if(CorrectExtension())