Home/ Questions/Q 7755983
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-06-01T12:42:09+00:00

Everything works fine, the only problem is that it loads very slow. It takes

  • 0

Everything works fine, the only problem is that it loads very slow. It takes 7 seconds to load a page containing 265 images. The images aren’t on a remote server, and they are thumbnails. They are being displayed at true height/width as well, so the server doesn’t have to resize them.

It shouldn’t be the getimagesize(), because in a previous iteration of the page every image also had a getimagesize() function and that loaded without the problem.

The only thing I can find that could be a problem would be the database. This is the setup:

TABLE albums:

| id | naam | urlnaam | actief |

TABLE fotos:

| id | url | ext | description | albumid |

So the albumid from fotos is linked to the id from albums.
Here’s the code:

$album = mysql_real_escape_string($_GET['fx2']);
mysql_select_db('user_fotos');
$i = 0;
$sql = mysql_query("SELECT a.naam, b.url, b.ext, b.description, b.id FROM albums AS a LEFT JOIN fotos AS b ON a.id = b.albumid WHERE a.urlnaam = '$album'");
while($row = mysql_fetch_assoc($sql)){
    if($i == 0){
        echo "Album: {$row['naam']}<br />";
        echo "<table><tr>";
    }
    if($i % 4 == 0){echo "</tr><tr>";}
    echo "<td align='center'>";
    $photourl = "http://www.mysite.com/fotos/$album/thumbs/" . $row['url'] . $row['ext'];
    $dimensions = getimagesize($photourl);
    $breedte = $dimensions[0];
    $lengte = $dimensions[1];
    if($breedte == '120'){$aspect="width='120px' height='{$lengte}px'";}else{$aspect="height='120px' width='{$breedte}px'";}
        echo "<div class='imageHolder' style='width:{$breedte}px; height:{$lengte}px;' onClick=\"parent.location='$album/{$row['id']}'\" /><img $aspect src='http://www.mysite.com/fotos/$album/thumbs/" . $row['url'] . $row['ext'] . "' alt='{$row['description']}' /></div>";
        echo "</td>";
        $i++;
}
echo "</tr></table>";
Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Editorial Team

    As others and myself have mentioned getting the imagesize() from a remote url will involve fetching the image slowing your script down:
    As I can see your using the actual dimensions so there is no need to actually fetch the size, also you may have some XSS problem with the album variable:
    Try this, your get the same result but much faster:

      <?php 
    $album = mysql_real_escape_string($_GET['fx2']);
    mysql_select_db('user_fotos');

    $sql = mysql_query("
    SELECT a.naam, b.url, b.ext, b.description, b.id 
    FROM albums AS a 
    LEFT JOIN fotos AS b ON a.id = b.albumid 
    WHERE a.urlnaam = '$album'");

    $i = 0;
    while($row = mysql_fetch_assoc($sql)){
        if($i == 0){
            echo "<p>Album: {$row['naam']}</p>";
            echo "<table><tr>";
        }
        if($i % 4 == 0){echo "</tr><tr>";}
        echo "<td align='center'>";
        echo "<div class='imageHolder' onClick=\"parent.location='".htmlentities($album)."/{$row['id']}'\" /><img src='./fotos/".htmlentities($album)."/thumbs/" . $row['url'] . $row['ext'] . "' alt='{$row['description']}' /></div>";
        echo "</td>";
        $i++;
    }
    echo "</tr></table>";
    ?>
    • 0