Question

Example 1:

int length()  
{  
        return strlen(random_string);  
}

Example 2:

int length()  
{  
        int str_length = 0;  
        str_length = strlen(random_string);  
        return str_length;  
}  

Question:
I have come across many functions where a single line of code could satisfy the requisite for that function, but I recall something about avoiding this kind of shortcut.

Are there certain situations where one is more appropriate than another or should I always go for the simpler piece of code.

Answer 1

One reason to have a a multi-step approach is that if you ever decide to add a line to print the value of length, it’s a lot less hassle:

int length()
{
    const int str_length = strlen(something);
    printf("str_length = %d\n", str_length);
    return str_length;
}

Or if you want to add some extra assert:

int length()
{
    const int str_length = strlen(something);
    assert(str_length >= 0);
    return str_length;
}

Other than that, it’s all about what you feel is most appropriate [unless you have strict coding standards to follow, of course!]