Question

Folks,

I wanted to send a few emails with different subject and body asynchronously. here is my code

Email.cs

 public string To;
 public string CC;
    public string Subject;
    public string Host;
    public string Port;
    public string Body;
    public MailMessage mail;
    public SmtpClient smtp;
  public void send()
        {
            smtp = new SmtpClient();
            mail = new MailMessage();                   
            mail.To.Add(To);            
            if (this.CC !="" && this.CC !=null) mail.CC.Add(CC);
            mail.CC.Add(CCIDBizzMail);             
            mail.Subject = this.Subject;
            mail.From = new MailAddress(From);            
            mail.IsBodyHtml = true;              
            smtp.Host = this.SMTPAddress; 
            mail.Body = this.Body;
            smtp.Credentials = new System.Net.NetworkCredential
                 (this.From, this.Password);            
            smtp.EnableSsl = false;
            smtp.SendCompleted  += new SendCompletedEventHandler(SendCompletedCallback);
            smtp.SendAsync(mail, null);
        }      
        private void SendCompletedCallback(object sender, AsyncCompletedEventArgs e)
        {           
            String token = (string)e.UserState;

            if (e.Cancelled)
            {               
            }
            if (e.Error != null)
            {

            }
            else
            {
                mail.Dispose();
                smtp.Dispose();
            }
        }

here is my code to send an email:

Email objEmail = new Email();    
objEmail.Subject = "Thank You for Your Order!";
objEmail.Body = "first email";
objEmail.To: "[e-mail]"
objEmail.Send();

objEmail.Subject = "Thank You for Your Order!";
objEmail.Body = "second email";
objEmail.To: "[e-mail]"
objEmail.Send();

However, [e-mail] never received an email. my website always send to [e-mail]

can you help me to solve this issue?

Answer 1

Here you try to send an email with Asynchronous type with out making a new object Email.

I suggest to try two thinks.

Make new on every email send

{
Email objEmail = new Email();    
objEmail.Subject = "Thank You for Your Order!";
objEmail.Body = "first email";
objEmail.To: "[e-mail]"
objEmail.Send();
}
{
Email objEmail = new Email();    
objEmail.Subject = "Thank You for Your Order!";
objEmail.Body = "second email";
objEmail.To: "[e-mail]"
objEmail.Send();
}

Or change the Email routine to

  public string To;
  public string CC;
  public string Subject;
  public string Host;
  public string Port;
  public string Body;

  public void send()
        {
            using(var smtp = new SmtpClient())
            {
            using(mail = new MailMessage())
            {
            mail.To.Add(To);            
            if (this.CC !="" && this.CC !=null) mail.CC.Add(CC);
            mail.CC.Add(CCIDBizzMail);             
            mail.Subject = this.Subject;
            mail.From = new MailAddress(From);            
            mail.IsBodyHtml = true;              
            smtp.Host = this.SMTPAddress; 
            mail.Body = this.Body;
            smtp.Credentials = new System.Net.NetworkCredential
                 (this.From, this.Password);            
            smtp.EnableSsl = false;
            // maybe here you place extra code for the errors
            // http://msdn.microsoft.com/en-us/library/swas0fwc.aspx
            smtp.Send(mail);
            }
            }
        }      

If the email is send using localhost and if you like to send many emails, is better to send them right way and not asynchronous.