Question

For my homework assignment, I need to implement Horners Algorithm for converting between bases.

I have been told to use getchar() for this assignment. But I am having a problem where when I hit enter, the program doesn’t terminate and just takes in more chars.

Example:

bryce> ./pa1
Enter the fromRadix:16

Enter the toRadix:2
abc
abc
^C
bryce> 

Code:

int readRadixA(int radixA)
{
    char myChar = getchar(); 
    int result = 0; 
    int run = 0; 

    while(myChar != EOF)
    {
        if(myChar == "\n")
            break;

        Horners();

        myChar = getchar(); 
    }

    return result;
}

I am not asking for help implementing Horners; I am asking for help to terminate the getchar() correctly.

Answer 1

if(myChar=="\n")
           ^  ^

You’re comparing myChar wrong. Try this instead:

if(myChar == '\n') 
             ^  ^

A second problem is that getchar returns int, not char. Maybe you can rewrite it like this:

int myChar;
while((myChar = getchar()) != EOF && myChar != '\n')
{
    /* Your stuff. */
}

EDIT

In light of comments, I think some stdio operation before that while is leaving a \n in the buffer.

Instead of scanf("%d", &radix) try:

scanf("%d ", &radix);
         ^

That space will make scanf eat the remaining blanks (including the newline).