Question

From what I read somewhere long time ago, it seems that if you want class member function to be inlined during the compilation phase, the function has to be defined inside class declaration block.

But this has a downside of a detail leak. IMHO, other programmers should only see class interface when opening .h file.

Is the first statement still true in modern C++, was it ever? Is there a way to force inlining for functions that are declared, preferably in another file altogether?

Is it generally better to keep short member functions inside class declaration block, or not?

Answer 1

It seems that if you want class member function to be inlined during the compilation phase, the function has to be defined inside class declaration block.

That is not really true. A function that is defined inside the class definition is implicitly marked as inline. But you don’t need to defined the function inside the class for it to be inline, you can explicitly request it:

struct X {
   void f();
};
inline void f() {}

The inline keyword on the other hand, does not mean that the function will be inlined, but rather that it can be defined in multiple translation units, that is, if multiple translation units include the same header that contains that definition, the linker will not fail with a multiple definition error.

Now, on actual inlining, the compiler can decide to inline or not any function, regardless of whether the function is declared as inline provided that it sees the definition of that function (the code that it will inline), which is the reason why in general functions that are meant to be inlined should be defined in the header (either inside the class definition or marked inline outside.

Additionally, newer toolchains can perform whole program optimization or other link time optimizations, by which the linker can also decide that a function should be inlined. In this case, the function definition needs not be visible at the call site, so it could be defined inside the .cpp file. But if you really want the function to be inlined it is better not to depend on this feature and just define the function in the header.