Question

function Cons(name) {
var pvar1="hi "+name;
sayhi = function() {
   alert(pvar1);
}
attEvents(){
$('#'+name).bind("click",sayhi);
}
}
var a = new Cons('name1');
var b = new Cons('name2');
var c = new Cons('name3');

Let us assume that name1, name2, name3 are all divs. Now, whatever div I click, I am always getting “hi name3”. The private variable is having the last stored value in it irrespective of the div clicked. Any help is appreciated.

Thanks

Answer 1

sayhi = function() {
   alert(pvar1);
}

If you define it without var keyword then it is defined as a global. Thus sayhi refers to the function defined as a last one. Use

var sayhi = function() {
   alert(pvar1);
}

or

var pvar1 = "hi "+name,
    sayhi = function() {
        alert(pvar1);
    };

Note the comma. Or true jQuery style

$('#'+name).bind("click", function() {
    alert(pvar1);
});