Question

Given the following helper method.

def link_tags(collection)
  tags = collection.split(',')

  tags.map.each do |tag|
    if tag == tags.last
      content_tag(:a, tag, href: tags_filter_post_path(tag) )
    else
      content_tag(:a, tag, href: tags_filter_post_path(tag) ) + ', '
    end        
  end.reduce(:<<)
end

How could I do a little refactor on this?

EDIT: The final code after the refactoring suggested.

def link_tags(collection)  
  collection.split(',').collect do |tag| 
    link = ""
    link += link_to tag, tags_filter_post_path(tag)
  end.join(', ').html_safe
end

Answer 1

def link_tags(collection)
  collection.split(',').map do |tag| 
    link_to tag, tag_filter_post_path(tag)
  end.join(', ')
end