Question

Handling files (opening) is an activity particularly prone to error.

If you were to write a function to do this (although trivial), what is the best way to write it in wrt handling errors?

Is the following good?

if (File.Exists(path))
{ 
    using (Streamwriter ....)
    { // write code }
}

else
// throw error if exceptional else report to user

Would the above (although not syntactially correct) a good way to do this?

Answer 1

First you can verify if you have access to the file, after, if the file exists and between the creation of the stream use a try catch block, look:

public bool HasDirectoryAccess(FileSystemRights fileSystemRights, string directoryPath)
{
    DirectorySecurity directorySecurity = Directory.GetAccessControl(directoryPath);

    foreach (FileSystemAccessRule rule in directorySecurity.GetAccessRules(true, true, typeof(System.Security.Principal.NTAccount)))
    {
        if ((rule.FileSystemRights & fileSystemRights) != 0)
        {
            return true;
        }
    }

    return false;
}

So:

if (this.HasDirectoryAccess(FileSystemRights.Read, path)
{
    if (File.Exists(path))   
    {  
        try
        {      
            using (Streamwriter ....)       
            { 
                // write code 
            }   
        }
        catch (Exception ex)            
        {    
            // throw error if exceptional else report to user or treat it                          
        } 
    }      
    else
    {
        // throw error if exceptional else report to user   
    }
}

Or you can verify all things with the try catch, and create the stream inside the try catch.