Question

Hello i need some help modifying this code so it splits this string with hyphens:

string KeyString = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890";

I would like to lay it out like this:

1234-1234-1234-1234

with a char length of 4 per segment and max chars about 16

Full Code

     private static string GetKey()
    {
        char[] chars = new char[62];
        string KeyString = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890";
        chars = KeyString.ToCharArray();

        RNGCryptoServiceProvider crypto = new RNGCryptoServiceProvider();

        byte[] data = new byte[1];
        crypto.GetNonZeroBytes(data);
        data = new byte[8];
        crypto.GetNonZeroBytes(data);

        StringBuilder result = new StringBuilder(8);

        foreach (byte b in data)
        {
            result.Append(chars[b % (chars.Length - 1)]);
        }

        return result.ToString();
    }

the code is used for generating random ids

any help would be appreciated

Answer 1

How about:

StringBuilder result = new StringBuilder();
for (var i = 0; i < data.Length; i++)
{
    if (i > 0 && (i % 4) == 0)
        result.Append("-");

    result.Append(chars[data[i] % (chars.Length - 1)]);
}
result.Length -= 1; // Remove trailing '-'