Question

Here are my for() loops :

public void showMovementCase(){
    int movePlusAttack = moveAllowed+attackDistance;
    int twiceMoveAllowed = (moveAllowed)*2;
    for(int i = 0; i <= movePlusAttack*2; i++){
        for(int j = 0; j <= movePlusAttack*2;j++){
            boolean a = movePlusAttack <= j+i && movePlusAttack >= j-i && i <= movePlusAttack;
            boolean b = movePlusAttack <= j+i && movePlusAttack >= i-j && i > movePlusAttack && j <= movePlusAttack;
            boolean c = movePlusAttack*3 >= j+i && movePlusAttack >= j-i && i > movePlusAttack &&  j >= movePlusAttack;
            if(a || b || c){
                try{
                    actionSquare[i][j] = new JLabel();
                    actionSquare[i][j].setIcon(redsquare);
                    actionSquare[i][j].setBounds(sprite.getX()+(i-movePlusAttack)*16,sprite.getY()+(j-movePlusAttack)*16, 16, 16);
                    panel.add(actionSquare[i][j], new Integer(1));
                }
                catch(ArrayIndexOutOfBoundsException e){System.out.println("red :" + e);}
            }
        }
    }
    for(int x = 0; x <= twiceMoveAllowed; x++){
        for(int y = 0; y <= twiceMoveAllowed;y++){
            boolean a = moveAllowed <= y+x && moveAllowed >= y-x && x <= moveAllowed;
            boolean b = moveAllowed <= y+x && moveAllowed >= x-y && x > moveAllowed && y <= moveAllowed;
            boolean c = moveAllowed*3 >= y+x && moveAllowed >= y-x && x > moveAllowed &&  y >= moveAllowed;
            if(a || b || c){
                try{
                    actionSquare[x][y].setIcon(bluesquare);
                    System.out.println("Coucou !");
                    actionSquare[x][y].addMouseListener(mouse);
                    panel.repaint();
                    panel.revalidate();
                }
                catch(ArrayIndexOutOfBoundsException e){System.out.println("blue :" + e); }
            }
        }
    }
}

if this.attackDistance is different of 0, then the second loop doesn’t work (it seems to stop at the .setIcon() command).

Do you know a way to fix this ?

Thanks for reading.

Edit:

with :

                try{
                    actionSquare[x][y].setIcon(bluesquare);
                    System.out.println("Coucou !");
[...]
                }

On the second loop, nothing is printed.

but with :

            try{
                System.out.println("Coucou !");
                actionSquare[x][y].setIcon(bluesquare);

[…]
}

“Coucou !” is printed once.
That’s why I said that “it seems to stop at the .setIcon() command” I should have said that sooner, sorry.

Answer 1

I cleaned up your code for you. Generally, when you have two sections of code that are supposed to be doing the exact same thing, but are not, then rolling them into one method can eliminate that possibility.

public void showMovementCase(){
    // probably want to remove anything left over from the last invocation
    panel.removeAll();
    for (JLabel[] array : actionSquare) Arrays.fill(array, null);
     
    colorSquares(moveAllowed + attackDistance, redsquare, null);
    colorSquares(moveAllowed * 2, bluesquare, mouse);
     
    for (int x = 0; x < actionSquare.length; x++)
        for (int y = 0; y < actionSquare[x].length; y++)
            if (actionSquare[x][y] != null) panel.add(actionSquare[x][y], 1);
}
 
private void colorSquares(int move, Icon color, MouseListener mouse) {
    int xMax = Math.min(2 * move, actionSquare.length);
    int yMax = Math.min(2 * move, actionSquare[0].length);
    for (int x = 0; x < xMax; x++) {
        for (int y = 0; y < yMax; y++) {
            if (isLegal(x, y, move)) {
                if (actionSquare[x][y] == null)
                    actionSquare[x][y] = new JLabel();
                actionSquare[x][y].setIcon(color);
                actionSquare[x][y].setBounds(
                        sprite.getX() + (x - move) * 16,
                        sprite.getY() + (y - move) * 16, 16, 16 );
                if (mouse != null) actionSquare[x][y].addMouseListener(mouse);
            }
        }
    }
}
 
private static boolean isLegal(int x, int y, int move) {
    // informative comment explaining why this mess makes sense
    if (move <= y+x && move >= y-x && x <= move) return true;
    // informative comment explaining why this mess makes sense
    if (move <= y+x && move >= x-y && x > move && y <= move) return true;
    // informative comment explaining why this mess makes sense
    if (move * 3 >= y+x && move >= y-x && x > move &&  y >= move) return true;
     
    return false;
}