Question

Here is my code, I’m trying to display a list of links to a bboy’s crews in sentence form with .to_sentence

<span class="affiliation">
    <% if(@bboy.crews.count > 0)%>
    <span><%= if(@bboy.crews.size > 1) then "Crew".pluralize else "Crew" end %>:</span>
    <%= @bboy.crews.collect{|c| link_to c.name, c}.to_sentence %>
    <% else %>  
    <em>Independent</em>
    <% end %>
</span>

The output I get is the correct links but it displays as:

<a href="/crews/1">Hustle Kidz</a> and <a href="/crews/2">Knuckleheads Cali</a>

rather than:

Hustle Kidz and
Knuckleheads
Cali

with the html escaped, rather than the desired links.

Am I missing something? I’ve tried CGI.unescapeHTML and a few others but am getting lost…

Answer 1

I agree with Kleber S, you should move this into a helper, because that’s a lot of logic for a view

def crews_description(crews)
  if crews.empty?
    content_tag('em', 'Independent')
  else
    label = "Crew"
    label = label.pluralize if crews.size > 1
    crews_links = crews.map {|crew| link_to(h(crew.name), crew)}.to_sentence
    content_tag('span', label) + crews_links.html_safe
  end
end

and in your view:

<span class="affiliation">
  <%= crews_description(@bboy.crews)
</span>