Question

Here is my fetch IDs function in DBAdapter class:
I want to fetch all the IDs and display the list in a toast message, cant understand where I am going wrong.

   public Cursor fetchAllIDs() {

         return mDb.query(DATABASE_TABLE0, new String[] {IDno1}, null, null, null, null,   null);
   }

Here is my function which I call on a button click and I want my toast to be filled with all IDs.

   private void fillData() {
       // Get all of the IDs from the database
          Cursor c = DBHelper.fetchAllIDs();
          startManagingCursor(c);

          String[] from = new String[] {DBAdapter.IDno1 };
          Toast.makeText(getApplicationContext(), ""+from, Toast.LENGTH_LONG).show();
}

Answer 1

First, you are returning a Cursor but then you never use the information in this Cursor.

Second, you cannot display a String[] as a string anyway. You’d have to loop through the String[] and display the values one by one.

You want something like this:

private void fillData() {
    Cursor c = DBHelper.fetchAllIDs();
    List<String> idList = new ArrayList<String>();
    if (c.moveToFirst()) {
        do {
            idList.add(c.getString(c.getColumnIndexOrThrow(IDno1)));
            Toast.makeText(getApplicationContext(), "" + idList.get(idList.size()-1), Toast.LENGTH_LONG).show();
        } while (c.moveToNext());
    }
}

Edit: Fixed getLong() to getString().