Question

Here is my Timer Elapsed Event, I am receiving the System.OutOfMemoryException on the line Thread thread = new Thread(threadStart);
I am receiving the error fairly fast (1~5 minutes, randomly), and it does not cause unexpected results in my program. I am just wondering what is causing this error, and I am afraid it may cause unexpected results if it is left unchecked. I have searched on the internet and am comming no where near the number of max threads.
readList contains about 46 enteries.

Any help would be appreciated.

private void glob_loopTimer_Elapsed(object sender, ElapsedEventArgs e)
{
    try
    {
        ParameterizedThreadStart threadStart = new ParameterizedThreadStart(readHoldingRegisters);
        foreach (readwriteDataGridRow.Read row in readList)
        {
            Thread thread = new Thread(threadStart);
            thread.IsBackground = true;
            thread.Start(System.Convert.ToInt32(row.Address));
        }
    }
    catch (Exception ex)
    {
        UpdateConsole(new object[] { ex.Message.ToString() + " " + ex.StackTrace.ToString(), Color.Red });
        Thread.CurrentThread.Abort(); // maybe?
    }
}

EDIT:
Here is a bit more information.
My program is reading registers from a Serial Device using the Modbus RTU protocol.
A single register takes less than a tenth of a second to retrieve from readHoldingRegisters

I am open to suggestions on what else to use rather than threads.
note: I need to call readHoldingRegisters 40 – 100 times in a single ‘pass’. The passes start when the user hits connect and end when he hits disconnect. Timers are not needed, they just offered a simple way for me to maintain the loop with a start and stop button.

EDIT: Solved

    private void glob_loopTimer_Elapsed(object sender, ElapsedEventArgs e)
{
    try
    {
        foreach (readwriteDataGridRow.Read row in readList)
        {
              readHoldingRegisters(row.Address);
        }
    }
    catch (Exception ex)
    {
        UpdateConsole(new object[] { ex.Message.ToString() + " " + ex.StackTrace.ToString(), Color.Red });
    }
}

The additional Threads were the problem and were not needed.

Answer 1

Ughh, do not, ever (well almost ever) abort threads. There are many preferable ways to make a System.Thread stop. Look around SO, you will find plenty of examples on why doing this is a bad idea and alternative approaches.

On with your question: The problem doesn’t seem to be the number of rows in readList. It is more likely that your glob_looperTimer_Elapsed event handler is being executed many times and you are basically starting more and more threads.

What is the interval of your glob_loopTimer?