Question

here is the following code which works just fine:

sCharacterUid = "394F73";
size_t pos;
sPos1 = sCharacterUid.substr(4,1);
sPos2 = sCharacterUid.substr(5,1);
sPos3 = sCharacterUid.substr(2,1);
sPos4 = sCharacterUid.substr(3,1);
sPos5 = sCharacterUid.substr(0,1);
sPos6 = sCharacterUid.substr(1,1);
sCharacterUid = sPos1 + sPos2 + " " + sPos3 + sPos4 + " " + sPos5 + sPos6;
String^ sfCharacterUid = gcnew String(sCharacterUid.c_str());

but I am wondering how I can cut down the amount of code needed to perform this task.

This is in c++/cli.

Thanks.

Answer 1

at first glance, why not

sPos1 = sCharacterUid.substr(4,2); 
sPos3 = sCharacterUid.substr(2,2);
sPos5 = sCharacterUid.substr(0,2);
sCharacterUid = sPos1 + " " + sPos3 + " " + sPos5; 

Or

string result="";
for (i=4;i>=0;i-=2)
  result += sCharacterUid.substr(i,2) + " ";

Or, it may be more efficient to work with raw chars.

char result=[9];
char* dest=result;
char* source = sCharacterUid.c_str();
for (i=4;i>=0;i-=2)
{
   *dest++ = source[i];
   *dest++ = source[i+1];
   *dest++ = ' ';
}
*(--dest)='\0';
String^ sfCharacterUid = gcnew String(result);