Question

Here what am trying to do:

1. I have a remote server (e.g:svr01,svr02,svr03). Using GetFileList to read the directory get all the files and match with the file name I have then copy to my local drive.

2. If any files matched then am adding them to an XML file also.

I was trying to do like below

 class Program
{
    static void Main(string[] args)
    {
        var getfiles = new fileshare.Program();

        string realname = "*main*";
        string Location = "SVR01";
        bool anymatch = false;
         foreach (var file in getfiles.GetFileList(realname,Location))
        {anymatch=true;}
         if (anymatch == true)
         { baseMeta(); }
        foreach (var file in getfiles.GetFileList(realname,Location))
        {getfiles.copytolocal(file.FullName); }

        }

    private FileInfo[] GetFileList(string pattern,string Location)
    {

        try
        {
            switch (Location)
            {
                case "SVR01":
                    {
                        var di = new DirectoryInfo(@"\\SVR01\Dev");
                        return di.GetFiles(pattern);
                    }
                case "SVR02":
                    {
                        var di = new DirectoryInfo(@"\\SVR02\Dev");
                        return di.GetFiles(pattern);
                    }
                case "SVR03":
                    {
                        var di = new DirectoryInfo(@"\\SVR03\Prod");
                        return di.GetFiles(pattern);
                    }
                default: throw new ArgumentOutOfRangeException();

            }
        }
        catch(Exception ex)
        { Console.Write(ex.ToString());
        return null;
        }

    }
    private void copytolocal(string filename)
    {
        string nameonly = Path.GetFileName(filename);
        File.Copy(filename,Path.Combine(@"c:\",nameonly),true);

    }

    private void baseMeta()
    {

                XmlWriter xmlWrite = XmlWriter.Create(@"c:\basexml");
                xmlWrite.WriteStartElement("job");
                xmlWrite.WriteElementString("Name", "test");
                xmlWrite.WriteElementString("time", DateTime);
                xmlWrite.Close();

    }
}

but this piece of code worries me because am doing the same process two times, any one please guide me how to avoid this.

 foreach (var file in getfiles.GetFileList(realname,Location))
 {
     anymatch=true;}
     if (anymatch == true)
     { 
          baseMeta(); 
     }
     foreach (var file in getfiles.GetFileList(realname,Location))
     {
         getfiles.copytolocal(file.FullName); 
     }
 }

Even am trying to find out if it match anyfile then i quit the first foreach loop generate the basemeta() then goes to next foreach loop to do the rest of the process.

Answer 1

Using LINQ you should be able to easily change your posted code into:

var getfiles = new fileshare.Program();
string realname = "*main*";
string Location = "SVR01";
var fileList = getFiles.GetFileList(realname, Location);
var anymatch = fileList.Any();

if (anymatch) // Or possibly `if (fileList.Any())` if anymatch isn't 
              // really used anywhere else
    baseMeta();

foreach (var file in getfiles.GetFileList(realname,Location))
    getfiles.copytolocal(file.FullName);

You’ll get the greatest benefit by replacing your GetFileList method with:

private IEnumerable<FileInfo> GetFileList(string pattern,string Location)
{
    string directory = string.Empty;

    switch (Location)
    {
        case "SVR01":
            directory = @"\\SVR01\Dev";
        break;

        case "SVR02":
            directory = @"\\SVR02\Dev";
        break;

        case "SVR03":
            directory = @"\\SVR03\Prod");
        break;

        default: 
            throw new ArgumentOutOfRangeException();

    }

    DirectoryInfo di = null;
    try
    {
        di = new DirectoryInfo(directory);
    }
    catch(Exception ex)
    {
        Console.WriteLine(ex.Message);
        yield break;
    }

    foreach(var fi in di.EnumerateFiles(pattern))
        yield return fi;
}