Question

Hey so I have all my code working and it’s fine. But I’d like to clean it up a little.

At the moment I just have a message box show if there is an error in the input, so it would show “Please check your input”, however I’d like it to show something like “Please check the following: firstname, secondname etc.”

if  ((FirstnameText.Text.Trim().Length == 0) || (SurnameText.Text.Trim().Length == 0)
    || (DateOfBirthText.Text.Trim().Length == 0) || (CourseText.Text.Trim().Length == 0)
    || (MatricNoText.Text.Trim().Length == 0) || (YearMarkText.Text.Trim().Length == 0)
    || (int.Parse(MatricNoText.Text) < 10000 || int.Parse(MatricNoText.Text) > 99999)
    || (int.Parse(YearMarkText.Text) < 0 ||  int.Parse(YearMarkText.Text) > 100))

   {
      errorMessage();
      return;
   }

public void errorMessage()
{
   MessageBox.Show("Please check your input");
}

I know it’s messy, but hey it works

Currently it just outputs that message, is there a simple way to output the specific textbox which has the error?

thanks

Answer 1

Splitting up your code would be a start:

if  ((FirstnameText.Text.Trim().Length == 0){
   errorMessage("firstname is empty");
}

if (SurnameText.Text.Trim().Length == 0){
   errorMessage("surname is empty");
}

Get the idea?