Question

Hi I am currently creating My SP that insert and detete records based on the result given by my select statement.

This is my sample Code:

DECLARE @PickListBatchName varchar(200),
@PartNumber varchar(50),
@QTY int;

SET @PickListBatchName='TEST1';
SET @PartNumber='PN1';
SET @QTY=1;


      --STEP 1 Add Result to TempTable
      With SN as
      (
        SELECT TOP (@QTY) 
           pb.PickListBatchId
           ,pt.PickListTRANId
           ,pt.SerialNumber
           ,pt.Createdby
           ,pt.CreatedDT
FROM PickListTRAN pt 
            LEFT JOIN PickListBatchDetail pdb ON pdb.PickListBatchDetailId=pt.PickListBatchDetailId
            LEFT JOIN PickListBatch pb ON pdb.PickListBatchId=pb.PickListBatchId
where  pb.PickListBatchName=@PickListBatchName AND pdb.PartNumber=@PartNumber
      )


    --STEP 2: INSERT SN TO PicklistTranCancel
    INSERT INTO PickListTRANCancel
   (
   PickListBatchId
   ,SerialNumber
   ,CreatedBy
   ,CreatedDT
   ) 
   (SELECT  
           PickListBatchId,
           SerialNumber,
           Createdby,
           CreatedDT
    FROM SN);

    --STEP 3: DELETE Records on PicklistTran

    DELETE FROM PicklistTran where picklistTranId IN (SELECT PickListTRANId FROM SN)

result:

(1 row(s) affected)
Msg 208, Level 16, State 1, Line 49
Invalid object name 'SN'.  --error on delete statement

On Step 3, the delete statement cannot read SN table. maybe i’m missing something on that part.

Thanks in Regards

Answer 1

Thanks @benni_mac_b and @praveen this is what i tried. I just use to create TempTable instead of using WITH.

DECLARE @PickListBatchName varchar(200),
@PartNumber varchar(50),
@QTY int;

SET @PickListBatchName='TEST1';
SET @PartNumber='PN1';
SET @QTY=1;

Declare @MyTable table 
(
     PickListBatchId int,
     PickListTRANId int,
    SerialNumber varchar(50),
    Createdby varchar(50),
    CreatedDT datetime
);


 --STEP 1: insert to temptable 
 INSERT INTO @MyTable
                    (
           PickListBatchId,
           PickListTRANId,
           SerialNumber,
           Createdby,
           CreatedDT
                    )
SELECT TOP (@QTY) 
           pb.PickListBatchId
           ,pt.PickListTRANId
           ,pt.SerialNumber
           ,pt.Createdby
           ,pt.CreatedDT
FROM PickListTRAN pt 
            LEFT JOIN PickListBatchDetail pdb ON pdb.PickListBatchDetailId=pt.PickListBatchDetailId
            LEFT JOIN PickListBatch pb ON pdb.PickListBatchId=pb.PickListBatchId
where  pb.PickListBatchName=@PickListBatchName AND pdb.PartNumber=@PartNumber


    --STEP 2: INSERT SN TO PicklistTranCancel
    INSERT INTO PickListTRANCancel
   (
   PickListBatchId
   ,SerialNumber
   ,CreatedBy
   ,CreatedDT
   ) 
   SELECT  
   PickListBatchId,
   SerialNumber,
   Createdby,
   CreatedDT
   FROM @MyTable

   --STEP 3: DELETE
   DELETE FROM PicklistTran where picklistTranId IN (SELECT PickListTRANId FROM @MyTable)