Question

Hi i am using the following code for uploding my file from android phone to the server bt the file does not upload completely..e.g i uploded a 11kb file and got only 8kb file at the server.What am i doing wrong?

Client side

Socket skt = new Socket"112.***.*.**", 3000);   

                String FileName=fil.getName();  

                            PrintWriter out2 = new PrintWriter(new BufferedWriter(new OutputStreamWriter(skt.getOutputStream())),true);                     
                out2.println("Upload");
                out2.println(FileName);         
                out2.println(spinindx); 
                out2.println(singleton.arrylst_setngs.get(0).toString());
                out2.println(singleton.arrylst_setngs.get(1).toString());               
                out2.println(singleton.arrylst_setngs.get(2).toString());
                out2.println(singleton.arrylst_setngs.get(3).toString());
                out2.println(singleton.arrylst_setngs.get(4).toString());

                out2.flush();
                //Create a file input stream and a buffered input stream.
                FileInputStream fis = new FileInputStream(fil);
                BufferedInputStream in = new BufferedInputStream(fis);
                BufferedOutputStream out = new BufferedOutputStream(skt.getOutputStream());

                //Write the file to the server socket           
                int i;          
                byte[] buf = new byte[512];

                while ((i = in.read(buf)) != -1) {                  
                    out.write(buf,0,i);

                    publishProgress(in.available());
                    System.out.println(i);
                }
                //Close the writers,readers and the socket.
                in.close();
                out.flush();
                out.close();                
                out2.close();               
                skt.close();
            }
            catch( Exception e ) {              
                System.out.println(e);
            }

The server side

InputStream inStream = socket.getInputStream();
                BufferedReader inm = new BufferedReader(new InputStreamReader(inStream));

                String Request=inm.readLine();  
if(Request.equals("Upload")){

                    fileName = inm.readLine();
                    chosn = inm.readLine();
                    lt=inm.readLine();
                    cs = inm.readLine();                                    
                    om = inm.readLine();
                    o = inm.readLine();
                    check=inm.readLine();                   



                    //Read, and write the file to the socket
                    BufferedInputStream in = new BufferedInputStream(inStream);         
                    int i=0;                    
                    File f=new File("D:/data/"+filePrefx+fileName);
                    if(!f.exists()){
                        f.createNewFile();

                    }
                    FileOutputStream fos = new FileOutputStream("D:/data/"+filePrefx+fileName);
                    BufferedOutputStream out = new BufferedOutputStream(fos);

                    byte[] buf = new byte[512];

                    while ((i = in.read(buf)) != -1) {
                        System.out.println(i);
                        out.write(buf,0,i);
                        System.out.println("Receiving data...");
                    }


                    in.close(); 
                    inStream.close();
                    out.close();    
                    fos.close();
                                        socket.close();

Answer 1

Looks like you are using both a BufferedReader and a BufferedInputStream on the same underlying socket at the server side, and two kinds of output stream/writer at the client. So your BufferedReader is buffering, which is what it’s supposed to do, and thus ‘stealing’ some of the data you’re expecting to read with the BufferedInputStream. Moral: you can’t do that. Use DataInputStream & DataOutputStream only, and writeUTF()/readUTF() for the 8 lines you are reading from the client before the file.