Question

Hi i have a login which connects to a server string and executes this when the login button is pushed. It returns the invalid error if the user and password is not stored on the database but it throws a “Index was outside on the bounds of array” error if they are on the database. How would i fix this??
Thanks

My connection string is located in my appconfig file, could the problem be in there?

##########FORM WINDOWS AFTER LOGIN BUTTON CLICK

private void btnOK_Click(object sender, EventArgs e)
{
SqlConnection con = Program.GetConnection;
SqlDataReader dr = null;
try
    {
            SqlCommand cmd = new SqlCommand("SELECT * FROM Users WHERE UserName='" +
            txtName.Text + "'AND Password='" + textpassword.Text + "'", con);
            dr = cmd.ExecuteReader();
            if (dr.Read())
            {
                Program.UserLoginName = dr.GetString(3);
                this.Close();
            }
            else

                MessageBox.Show("Invalid Username & Password!");

        }
        catch (Exception ex)
        {
            MessageBox.Show(ex.Message);
        }
    }

#######PROGRAM.CS FILE

Using System;
using System.Collections.Generic;
using System.Linq;
using System.Windows.Forms;
using System.Data.SqlClient;
using System.Configuration;  

namespace FrontEndV1
{
static class Program
{
    /// <summary>
    /// The main entry point for the application.
    /// </summary>
    [STAThread]
    static void Main()
    {
        Application.EnableVisualStyles();
        Application.SetCompatibleTextRenderingDefault(false);
        Application.Run(new Login());
    }
    public static SqlConnection GetConnection
    {
        get
        {
            string ConnectionString = ConfigurationManager.ConnectionStrings["FrontEndV1Connection"].ConnectionString;
            SqlConnection con = new SqlConnection(ConnectionString);
            con.Open();
            return con;
        }
    }
    public static string UserLoginName { get; set; }
}

}

Answer 1

I think that mistake lays here: dr.GetString(3); try to change 3 to 2. Numeration begins from 0 in arrays.