Question

How are you formatting your try..catch.finally blocks? Especially when only wrapping it around a small amount of code, it blows everything and makes code pretty unreadable and unsightly in my opinion.

Such as:

try
{
     MyService service = new Service();
     service.DoSomething();
     return something;
}
catch (Exception ex)
{
     LogSomething();
     return somethingElse;
}
finally
{
     MarkAsComplete();
     service.Dispose();
}

These 7 lines of code turned into a 16-line mess.

Any suggestions on better try..catch..finally formatting?

Answer 1

Actually, this reads very well to me. If your actual code looks a lot like this, then I really wouldn’t worry about it. It is VERY clear what is happening.

If your actual code is more complex, then consider breaking the blocks into well-named methods.