Question

How can I add a trailing slash to:

RewriteEngine on
RewriteRule !\.(js|ico|gif|jpg|png|css|html)$ index.php

I have tried with:

RewriteCond %{REQUEST_FILENAME} !-f
RewriteRule ^(.+[^/])$ $1/ [R]

But it’s not working

Answer 1

See the detail/description line for the CondPatterns -d and -f for RewriteCond. See how it says “tests whether or not it exists, and is a regular file”? That is expensive and does not scale well at all. Do you really care if it’s “a regular file”? No, you only care if it looks like a file. (matches the filename.extension pattern) So, I’m going to improve your Rewrite while I’m at it.

See the detail/description for the ‘last|L’ flag for RewriteRule. See how it says “don’t apply any more rewrite rules”? I bet that’s what you want isn’t it? You want either index.php to be used when a request doesn’t match the extension of a static asset, OR you want to put a slash on the end of a request that doesn’t match the filename.extension pattern. Not both.

Here’s how you do that:

# turn on matching
RewriteEngine on

# 1st rule block. If any of the conditions don't apply skip over this block to the next.
# condition: uri ends with filename.extension
RewriteCond %{REQUEST_URI}  [^/.]+\.[^/.]+$
# condition: uri doesn't end with a desired extension
RewriteCond %{REQUEST_URI}  !\.(js|ico|gif|jpg|png|css|html)$ [NC]
# rewrite the request to be for index.php and don't apply any more rules
RewriteRule -  index.php [L]

# 2nd rule block. If any of the conditions don't apply skip over this block to the next.
# condition: uri doesn't end with a slash
RewriteCond %{REQUEST_URI}  !/$
# condition: uri doesn't end with filename.extension
RewriteCond %{REQUEST_URI}  !/[^/]+\.[^/.]+$
# rewrite the request to be appended with a slash
RewriteRule (.*)  $1/ [R=301]

This is a very good answer considering that you didn’t tell us want you are trying to do. If you want a better answer, you’ll need to give us more info than “I copied and pasted 2 code snipets together, but it’s not working.”

---

Update: I hastily threw together an edit to this answer based on cornegigouille’s answer. Here is a bash shell transcript of the proof I did to test it. Let me know if you see a bug.

#bruno:~$ (
for str in asdf asdf.css asdf.min.css; do
    echo -e "\n## $str ##"
    echo /brunobronosky1/$str | grep -E '/[^/.]+\.[^/.]+$' || echo '[no match]'
    echo /brunobronosky2/$str | grep -E '/[^/]+\.[^/.]+$' || echo '[no match]'
    echo /cornegigouille/$str | grep -E '/[^/.]+(\.[^/.]+)+$' || echo '[no match]'
done
)

## asdf ##
[no match]
[no match]
[no match]

## asdf.css ##
/brunobronosky1/asdf.css
/brunobronosky2/asdf.css
/cornegigouille/asdf.css

## asdf.min.css ##
[no match]
/brunobronosky2/asdf.min.css
/cornegigouille/asdf.min.css