Question

How can I change following query, so that I’m able to parameterize the SparePartNames?

It returns all ID’s of repairs where not all mandatory spareparts were changed, in other words where at least one part is missing.

Note that the number of spareparts might change in future not only the names. Is it possible without using a stored procedure with dynamic SQL? If not, how could this SP look like?

Edit: Note that i do not need to know how to pass a list/array as parameter, this is asked myriads of time on SO. I’ve also already a Split table-valued-function. I’m just wondering how i could rewrite the query to be able to join(or whatever) with a list of mandatory parts, so that i’ll find all records where at least one part is missing. So is it possible to use a varchar-parameter like '1264-3212,1254-2975' instead of a list of NOT EXISTS? Sorry for the confusion if it was not clear in the first place.

SELECT  d.idData
FROM    tabData d
INNER JOIN modModel AS m ON d.fiModel = m.idModel 
WHERE  (m.ModelName = 'MT27I') 
AND (d.fiMaxServiceLevel >= 2) 
AND (d.Manufacture_Date < '20120511') 
AND (NOT EXISTS
      (SELECT NULL
        FROM  tabDataDetail AS td 
        INNER JOIN tabSparePart AS sp ON sp.idSparePart = td.fiSparePart
        WHERE (td.fiData = d.idData) 
        AND (sp.SparePartName = '1264-3212'))
    OR (NOT EXISTS
      (SELECT NULL
        FROM  tabDataDetail AS td 
        INNER JOIN tabSparePart AS sp ON sp.idSparePart = td.fiSparePart
        WHERE (td.fiData = d.idData) 
        AND (sp.SparePartName = '1254-2975'))
    )
)

Unfortunately I don’t see how I could use sp.SparePartName IN/NOT IN(@sparePartNames) here.

Answer 1

Assuming there is (or will be) a table or view of mandatory spare parts, a list of exists can be replaced with a left join to tabDataDetail / tabSparePart pair on SparePartName; non-matches are reported back using td.fiSparePart is null.

; with mandatorySpareParts (SparePartName) as (
  select '1264-3212'
  union all
  select '1254-2975'
)
SELECT  d.idData
FROM    tabData d
INNER JOIN modModel AS m ON d.fiModel = m.idModel 
WHERE  (m.ModelName = 'MT27I') 
AND (d.fiMaxServiceLevel >= 2) 
AND (d.Manufacture_Date < '20120511') 
AND exists
(
  SELECT null
    from mandatorySpareParts msp
    left join ( tabDataDetail AS td 
                INNER JOIN tabSparePart AS sp 
                   ON sp.idSparePart = td.fiSparePart 
                  AND td.fiData = d.idData
              )
      ON msp.SparePartName = sp.SparePartName
   WHERE td.fiSparePart is null
)

Part names should be replaced by their id’s, which would simplify left join and speed the query up.

EDIT: i’ve errorneously left filtering of td in where clause, which invalidated left join. It is now in ON clause where it belongs.