Question

How can I do this better (so it actually works : )

I have a LINQ Query that includes an order by that is based on a user preference. The user can decide if they would like the results ordered asc or desc.

If fuserclass.SortOrder = "Ascending" Then
   Dim mydat = (From c In dc.ITRS Order By c.Date Ascending Select c)
Else
   Dim mydat = (From c In dc.ITRS Order By c.Date Descending Select c)
End If

For each mydata in mydat ***<<<error "mydat is not declared"***

I know I could put my For Each loop inside the If and Else, but that seems silly to have the same code twice. I know you know of a better way : )

Answer 1

Use an extension method, and function-based LINQ (my VB is rusty as hell)

VB.NET:

<ExtensionAttribute> _
Public Shared Function OrderByString(Of TSource, TKey) ( _
source As IEnumerable(Of TSource), _
keySelector As Func(Of TSource, TKey) _
    strType As String) As IOrderedEnumerable(Of TSource)

    If strType = "Ascending" Then
        return source.OrderBy(keySelector)
    Else
        return source.OrderByDescending(keySelector)
    End If
End Function

C#.NET:

public static IOrderedEnumerable<TSource> OrderByString(
    this IEnumerable<TSource> source, 
    Func<TSource, TKey> keySelector,
    string strType)
{
    if (strType == "Ascending")
        return source.OrderBy(keySelector);
    return source.OrderByDescending(keySelector);
}

Then call your query like this:

Dim mydat = dc.ITRS.OrderByString(Function(item) item.Date, fuserclass.SortOrder)

Or on C#:

var mydat = dv.ITRS.OrderbyString(item => item.Date, fuserclass.SortOrder);