Question

how can i eliminate multiple number of return statements to one statement. example: i hav one if clause, the result of the if clause is true it will return 0. or return 1, the else of the same if contains another if clause. it has also the return value. how can i eleiminate this four return statement to one?

this is the program

if (IgC == true)
        {
            if (val1.ToUpper() == val2.ToUpper())
            {
                return 0;
            }
            else
            {
                return 1;
            }
        }

        else
        {
            if (val1 == val2)
            {
                return 0;
            }

            else
            {
                return 1;
            }
        }

Answer 1

Here is my guess at the logic…

int retVal;

if (condition) 
{
  // statements
  retVal = 0;
}
else 
{
  // statements
  if (otherCondition)
  {
    retVal = 1;
  }
  else
  {
    retVal = 2;
  }
}

return retVal;

and with your now-posted update:

int retVal;

if (IgC)
   retVal = (val1.ToUpper() == val2.ToUpper()) ? 0 : 1;
else
   retVal = (val1 == val2) ? 0 : 1;

return retVal;

I avoid nesting ternary operators or check more than one condition with them, as that makes the code obscure really fast. It is not that the code gets any less efficient if you are more explicit, so the whole thing is solely about readability.

I try to weigh code length and visual complexity against expressiveness, and the if/ternary combination seems to be good middle ground for me.