Question

How could I compact this logic?

an_array = some_list.select do |item|                                  
  include_item = true                                                        
  if a_boolean                                                                  
    include_item = a_method?(item)                                     
  end                                                                        
  include_item                                                               
end   

Answer 1

I urge you to post some more sensible examples; meta-variables lead into the dark side. In your case, In your case, if a_boolean is false, the code basically evaluates an_array = some_list.clone, but in slow motion. Thus, it would be more sensible to write

an_array =
  if a_boolean
    some_list.select { |item| a_method?(item) }
  else
    some_list.clone
  end

And I still have no clue if it’s actually good, because your intention is completely impenetrable by using overgeneric code.

EDIT: Added .clone.

EDIT2: As noted in comments, meagar and my meandering brain eventually arrived at the sameish place:

an_array = some_list.clone
an_array.select! { |item| a_method?(item) } if a_boolean