Question

How to solbe this memory leak … I even release it at the end as in the pic but its still there. In if statment almost 10-15 condition its using like the given code… But at the end I release it.

LoginResponse *response = [[LoginResponse alloc] initWithMessageString: messageString];


ServerMessage *ackMessage = [[ServerMessage alloc] initWithMessageToAck:response];
[[NSNotificationCenter defaultCenter] postNotificationName:@"SendMessageToServer" object:ackMessage];

[[NSNotificationCenter defaultCenter] postNotificationName:@"LoginResponseReceived" object:response];

Answer 1

You’re not releasing messageString. What you’re doing is this:

// there's a messageString
if(...){
     NSString* messageString= [[NSString alloc] init ... ]
                                   // you're declaring new messageString, 
                                   // not related to the outer messageString
     ...
     // and you didn't release the inner messageString. 
     // The pointer messageString just goes away.
}
[messageString release]; // you're releasing outer messageString, not inner messageString.

Perform “Analyze” from XCode. (It’s below the “build” menu item.) I think that should capture this problem of forgetting to release the inner messageString. Use “Analyze” before running Instruments.