Question

I added a new element in the js.erb file and I am trying to assign a click event to the newly added element.

This is what I have in js.erb:

$("#<%= linkid %>").on("click", '<%= j function(event) {$(this).parent().next().toggle(); event.preventDefault();}) %>' );

I am getting syntax error using “$” writing the function. what is the fix here? If I have to put this function in a var within this file, how do I do it? Generally, is there a better way?

Update: error message

/create.js.erb:7: syntax error, unexpected $undefined
....append= ( j function(event) {$(this).parent().next().toggle...
...                               ^
/create.js.erb:7: syntax error, unexpected ')', expecting keyword_end
...(); event.preventDefault();}) );@output_buffer.safe_concat('...
...                               ^):

Answer 1

Things inside <%= ... %> are supposed to be Ruby expressions, not JavaScript. This:

<%= j function(event) {$(this).parent().next().toggle(); event.preventDefault();}) %>

doesn’t need the ERB at all, that’s just plain old JavaScript. Also, the second argument to jQuery’s $(...).on('click', ...) should be a JavaScript function, not a JavaScript string. You want this:

$("#<%= linkid %>").on("click", function(event) {
    $(this).parent().next().toggle();
    event.preventDefault();
});