Question

I am a beginner learning C; so, please go easy on me. 🙂

I am trying to write a very simple program that takes each word of a string into a “Hi (input)!” sentence (it assumes you type in names). Also, I am using arrays because I need to practice them.

My problem is that, some garbage gets putten into the arrays somewhere, and it messes up the program. I tried to figure out the problem but to no avail; so, it is time to ask for expert help. Where have I made mistakes?

p.s.: It also has an infinite loop somewhere, but it is probably the result of the garbage that is put into the array.

#include <stdio.h>
#define MAX 500 //Maximum Array size.

int main(int argc, const char * argv[])
{
    int stringArray [MAX];
    int wordArray [MAX];
    int counter = 0;
    int wordCounter = 0;

    printf("Please type in a list of names then hit ENTER:\n");  
    // Fill up the stringArray with user input.
    stringArray[counter] = getchar();
    while (stringArray[counter] != '\n') {
        stringArray[++counter] = getchar();
    }

    // Main function.
    counter = 0;
    while (stringArray[wordCounter] != '\n') {     
        // Puts first word into temporary wordArray.
        while ((stringArray[wordCounter] != ' ') && (stringArray[wordCounter] != '\n')) {
            wordArray[counter++] = stringArray[wordCounter++];
        }
        wordArray[counter] = '\0';

        //Prints out the content of wordArray.
        counter = 0;
        printf("Hi ");
        while (wordArray[counter] != '\0') {
            putchar(wordArray[counter]);
            counter++;
        }
        printf("!\n");

        //Clears temporary wordArray for new use.
        for (counter = 0; counter == MAX; counter++) {
            wordArray[counter] = '\0';
        } 
        wordCounter++;
        counter = 0; 
    }
    return 0;
}

Solved it! I needed to add to following if sentence to the end when I incremented the wordCounter. 🙂

    if (stringArray[wordCounter] != '\n') {
            wordCounter++;
    }

Answer 1

    for (counter = 0; counter == MAX; counter++) {
        wordArray[counter] = '\0';
    } 

You never enter into this loop.