Question

I am attempting to create a singleton service that is used to process incoming requests to an HttpHandler. At the moment the service is being instantiated on every request. I make a call to the static class that holds an instance of the service, implemented as a singleton as below:

 public static class ServerApplication {

static Service instance = null;
static readonly object padlock = new object();

/// <summary>
/// Service singleton.
/// </summary>
public static Service Service {
  get {
    lock (padlock) {
      if (instance == null) {
        instance = new Service();
      }
      return instance;
    }
  }
}

And access it using a call as below in the HttpHandler:

ServerApplication.Service.Process(request);

I have set a breakpoint on the instance = new Service(); line and with multiple requests the
breakpoint is triggered per request.

My aim is a service that exists across requests as it loads and caches lots of data from files and databases that is reused with most requests.

Can anyone see what is going wrong?

Answer 1

A couple of things:

• If it’s a multiprocessor box, technically, you should mark the shared service instance with the “volatile” keyword or use a call to MemoryBarrier (see http://blogs.msdn.com/brada/archive/2004/05/12/130935.aspx). You didn’t specify architecture, so hard to say if this is really the issue, but better safe than sorry.
• You should implement a double-check lock (eg, check for null both before and after acquiring the lock on “padlock”). This way you’re doing a much cheaper comparison instead of acquiring a lock on all the subsequent reads.

That should cover you on the concurrency fronts. It’s also possible (though less likely) that your AppDomain is being unloaded between requests (ie, you wrote a file inside the web directory causing ASP.NET to think your app is stale), which would cause the statics to be reset.