Question

I am coding an image puzzle game and one part of the code is to compare the pieces the user has selected to the pieces of the correct image.

Each image piece is already added to a JButton as an ImageIcon.

An identifier is required to differentiate each image piece apart and also for comparision.

I am setting a setName() for each JButton created as the identifier.

The comparison starts when the user releases the mouse after he drags the puzzle pieces from the original 3×3 grid where the shuffled pieces are to the other 3x grid for matching.

I have problems removing the error from the comparison if statement.

I got the comparison idea from this SO thread – link

    private JButton[] button = new JButton[9];
    private JButton[] waa = new JButton[9];

    private String id;
    private int cc;
    private String id2;
    private int cc2;

    // setName for each of the 9 buttons in the original 3x3 grid being created 
    // which stores the shuffled puzzle pieces
    for(int a=0; a<9; a++){
        button[a] = new JButton(new ImageIcon());
        id += Integer.toString(++cc);
        button[a].setName(id); 
    }

    // setName for each of the 9 buttons in the other 3x3 grid  
    // where the images will be dragged to by the user
        for(int b=0; b<9; b++){
        waa[b] = new JButton();
        id2 += Integer.toString(++cc2);
        waa[b].setName(id2); 
    }

    // check if puzzle pieces are matched in the correct place
    // compare name of original 'button' array button with the name of 'waa' array buttons 
        button[a].addMouseListener(new MouseAdapter(){

            public void mouseReleased(MouseEvent m){
                if(m.getbutton().getName().equals (waa.getName())){

                    }
                    else{
                         JOptionPane.showMessageDialog(null,"Wrong! Try Again.");
                    }
            }
        }

Answer 1

In your mouseReleased event m.getButton() is returning the mouse button that was clicked. You’ll want to do something more like this that will get you closer:

if (m.getComponent().getName().equals(waa.getName())) {

m.getComponent() returns the Component object (your JButton) that the event was fired from. From there you can do the comparison with the getName approach you are using.

There’s an additional issue in that your waa variable is an array. I’m not sure how you want to compare them, whether running through the arrays and making sure the index and names match, but that’s an additional issue you need to look into.