Question

I am creating an event driven class so that when I pass it a series of data, it will process and then return the value when ready.

Below is the code that I am currently using the below code however it is quite nasty and I’m not sure if can be simpler than this.

   public delegate void MyEventHandler(double result);

    public static MyEventHandler EventComplete;

    public static void MakeSomethingHappen(double[] data)
    {
        ThreadPool.QueueUserWorkItem(DoSomething, data);
    }
    private static void DoSomething(object dblData)
    {
        InvokeEventComplete(AndSomethingElse((double[])dblData));
    }

    private static void InvokeEventComplete(double result)
    {
        if (EventComplete != null)
        {
            EventComplete(result);
        }
    }

    public static double AndSomethingElse(double[] data)
    {
         //do some code
         return result; //double
    }

In my main class I simply hook up a method to the event like so,

MyClass.EventComplete += new MyClass.EventCompleteHandler(MyClass_EventComplete);

Answer 1

Here you are:

• Exposed event as an actual event rather than a publicly accessible member delegate.
• Eliminated extra delegate declaration and used generic delegate Action.
• Eliminated extra invocation function which was simply verbose.
• Used lambda expression for event registration.

Edited code is:

MyClass.EventComplete += (result) => Console.WriteLine("Result is: " + result);

public class MyClass
{
    public static event Action<double> EventComplete;

    public static void MakeSomethingHappen(double[] data)
    {
        ThreadPool.QueueUserWorkItem(DoSomething, data);
    }

    private static void DoSomething(object dblData)
    {
        var result = AndSomethingElse((double[])dblData);

        if (EventComplete != null)
        {
            EventComplete(result);
        }
    }

    public static double AndSomethingElse(double[] data)
    {
        //do some code
        return result; //double
    }
}