Question

I am currently studying C# and I really want to get a good coding style from the beginning, so I would like to hear opinions from you professionals on this matter.

Should you always (or mostly) use local variables for conditions/calculations (example 2) or is it just as good/better to use statements directly (example 1)

Example 1.

if (double.TryParse(stringToParse, out dblValue)) ...

Example 2.

bool parseSuccess = double.TryParse(stringToParse, out dblValue);
if (parseSuccess) ...

It would be interesting to hear your thoughts and reasoning at this example.

Answer 1

You should use the more verbose style if putting it all in one line would make it too long or complicated.

You should also use a separate variable if the variable’s name would make it easier to understand the code:

bool mustWait = someCommand.ConflictsWith(otherCommand);
if (mustWait) {
    ...
}

In such cases, you should consider using an enum for additional readability.