Question

I am currently trying to add to an object through a function.

My code is:

var ob = {};

function add(f, fun) {
    ob[f] = fun();
}

add('hi', function() {
    alert('hello')
})

ob.hi()​

So this is suppose to change ob to:

var ob = {
     hi: function(){
      alert('hello')
     }
}

It does alert hello but just from the triggering of the add function (which I want to stop) and not from the ob.hi() function.

Thanks for any help. If you want you can also check the fiddle

Answer 1

You are executing the function and assigning its return value to the property. You need to assign a reference to the function to the property instead. Change your add function:

function add(f, fun) {
    ob[f] = fun; //No invoking parentheses!
}

Here’s an updated fiddle.

If you look at the console in your original fiddle you get a hint of what’s going wrong:

Uncaught TypeError: Property ‘hi’ of object #<Object> is not a
function