Question

I am defining a buffered writer in a class I am developing, but having problems with it.

In the class constructor I am defining:

public class RestHandler  {
public static BufferedWriter rest_logger;

public RestHandler(parsedXMLConfigData _config, BufferedWriter writer) {
    rest_logger = writer;
    try {
        rest_logger.write("RestHandler instance finished init and ready to receive calls!" + "\n");
    } catch (IOException e) {
        // TODO Auto-generated catch block
        e.printStackTrace();
    }
}

This works and prints the text to my file. But when I try to use the same rest_logger in another one of my class methods:

    @POST
@Path("{subResources: [a-zA-Z0-9_/]+}")
public void postHandler
(
        @Context final UriInfo uriInfo,
        @PathParam("subResources") String subResources) {

    try {
        rest_logger.write("TEXT...");
    } catch (IOException e) {
        // TODO Auto-generated catch block
        e.printStackTrace();
    }
    }

It gives me a stream closed exception! I should mention that I use this to close the stream:

    protected void finalize() throws Throwable {
    rest_logger.close();
}

Answer 1

There are several problems with your code:

• the rest_logger variable should not be static
• you shouldn’t initialize it to a new BufferedWriter just to discard it afterwards and reinitialize it with the writer argument (that you have no control on)
• you shouldn’t ignore exceptions. If you don’t know what to do with them, make your methods throw IOException and let the caller decide what to do
• you should not use finalizers
• you should not close a writer that you have not created. Let the opener of the writer close it.

Other than that, and since your code doesn’t make much sense, it’s hard to understand what the code is supposed to do.