Question

I am designing a stored procedure to return results from a search.

I need all apartments returned that has a specific zipcode..

The select should do what this does:

select * from tbl_houses
where

(
  (zip_code in (10000,20000,30000,40000))
  or
  (zip_code > 50000 and zip_code < 60000)
)

In other words. I want a stored procedure which can both take a zip_code range and series of zip_codes.

Anyone know an elegant way of doing this?

My current solutions are ugly as xxxx.

Cheers
Mathias

Answer 1

You can use a Split Table-value function for this:

CREATE FUNCTION [dbo].[Split](@RowData VARCHAR(8000), @SplitOn VARCHAR(5))  
RETURNS @RtnValue TABLE 
(
    Id int identity(1,1),
    Data nvarchar(2000)
) 
AS  
BEGIN 
    Declare @Cnt int
    Set @Cnt = 1

    While (Charindex(@SplitOn,@RowData)>0)
    Begin
        Insert Into @RtnValue (data)
        Select 
            Data = ltrim(rtrim(Substring(@RowData,1,Charindex(@SplitOn,@RowData)-1)))

        Set @RowData = Substring(@RowData,Charindex(@SplitOn,@RowData)+1,len(@RowData))
        Set @Cnt = @Cnt + 1
    End

    Insert Into @RtnValue (data)
    Select Data = ltrim(rtrim(@RowData))

    Return
END

Then you can use it on your stored procedure, maybe with another parameter indicating if its a range or a list:

CREATE PROCEDURE dbo.GetHouses(@Zip VARCHAR(8000), @Type INT)
AS
/* 
  @Type:    1 - List
            2 - Range
*/

IF @Type = 1
BEGIN
    SELECT * 
    FROM tbl_houses H
    JOIN dbo.Split(@Zip, ',') S
    ON H.zip_code = S.Data
END
IF @Type = 2
BEGIN
    SELECT * 
    FROM tbl_houses
    WHERE zip_code >= (SELECT Data FROM dbo.Split(@Zip, ',') WHERE Id  = 1)
    AND zip_code <= (SELECT Data FROM dbo.Split(@Zip, ',') WHERE Id  = 2)
END