Question

I am doing some form validation on a project with javascript. what im doing works but it seems like there might be a better way to do it. here is an example of what i have.

onkeypress="return keyNumOnly(event)"
function keyNumOnly(key)
{//this allows numbers and decimals.   
    var keychar;
    var numcheck;
    var keynum;
    if(window.event) // IE
        {
            keynum = key.keyCode;
        }     
    else if(key.which) // Netscape/Firefox/Opera
        {
            keynum = key.which;
        }
    if (keynum==8)
        {
            return true;
        }
    keychar = String.fromCharCode(keynum);
    numcheck = /\d/;
    if (keychar== ".")
        {
            return true;    
        }
    return numcheck.test(keychar);
}

Answer 1

Some cleanup:

someTextbox.onkeypress = function(event) { // you can pass a function directly
    var event    = event || window.event, 
        // this means: event or window.event if event does not exist

        keynum   = event.keyCode || event.which,
        // event.keyCode or event.which otherwise

        keychar  = String.fromCharCode(keynum),

        numcheck = /\d/;


    if(/\t|\./.test(keychar)) {
        // checking for dot or tab using a regexp: \t is tab, | means 'or', \. is dot
        return true;
    }


    return numcheck.test(keychar);
}