Question

I am generating an html dropdown and I currently have the code to select the data from the database and generate the result in the view? Is this ok, or should I be placing it in the controller somehow. If so, how do I call that data from the view? This is my code:

<select id="f_treeindex">
            <?php
                $query = $this->db->query('SELECT id, tree_name FROM trees');

                foreach ($query->result() as $row)
                {
                    echo '<option value="' . $row->id . '">' . $row->tree_name . '</option>';
                };
            ?>
</select>

I want to keep as much DB data out of my views as possible.

REVISED:

MODEL:

function get_tree(){
    $query = $this->db->query('SELECT id, tree_name FROM trees');
    return $query->result_array();
}

CONTROLLER:

$data['trees'] = $this->Model_form->get_tree();

    if ($this->form_validation->run() == FALSE)
    {
        $this->load->view('view_form_group', $data);
    }

VIEW:

<?php
        foreach($trees as $tree){
            echo '<option value="' . $tree->id . '">' . $tree->tree_name . '</option>';
        }
        ?>

Answer 1

Query goes in the Tree model where you have a function something like get_trees(), and you call it from the controller with something like $trees = $this->Tree->get_trees();

Then you pass it to the view and loop through it. That’s the MVC way.

For your REVISED code you should also add in the Model “return $query->result_array();”