Question

I am getting this error while following the tutorial from railstutorial.org.

Model class : $APPLICATION_HOME/app/models/user.rb

# == Schema Information
#
# Table name: users
#
#  id         :integer         not null, primary key
#  name       :string(255)
#  email      :string(255)
#  created_at :datetime        not null
#  updated_at :datetime        not null
#

class User < ActiveRecord::Base

  attr_accessible :name, :email, :password, :password_confirmation
  has_secure_password

  #validations
  validates :name, presence: true, length: { maximum: 50}

  valid_email_regex = /\A[\w+\-.]+@[a-z\d\-.]+\.[a-z]+\z/i
  validates :email, presence: true, format: { with: valid_email_regex },
            uniqueness: { case_sensitive: false } 

  validates :password, length: { minimum: 6 }

end

View page : $APPLICATION_HOME/app/views/show.html.erb file

<% provide :title, @user.name %>
<h1><%= @user.name %></h1>

RSpec file : $APPLICATION_HOME/app/spec/requests/user_pages_spec.rb

 require 'spec_helper'

    describe "UserPages" do

      subject { page }

      describe "signup page" do

        before { visit signup_path }

        it { should have_selector('h1', text: "Sign up") }
        it { should have_selector('title', text: full_title('Sign up')) }

      end

      describe "profile page" do
        let(:user) { FactoryGirl.create(:user) }
        before { visit user_path(user) }

        it { should have_selector('h1',    text: user.name) }
        it { should have_selector('title', text: user.name) }
      end
    end

Here is factories.rb which I have put in $APPLICATION_HOME/spec/factories.rb

FactoryGirl.define do
  factory :user do
    name     "amit"
    email    "[e-mail]"
    password "foobar"
  end
end

A snapshot of Gemfile

group :test do
  gem 'capybara', '1.1.2'
  gem 'factory_girl_rails'
end

Here is log I am getting while testing the spec.

Failures:

  1) UserPages profile page 
     Failure/Error: before { visit user_path(user) }
     ActionView::Template::Error:
       undefined method `name' for nil:NilClass
     # ./app/views/users/show.html.erb:1:in `_app_views_users_show_html_erb__369651065_78543920'
     # ./spec/requests/user_pages_spec.rb:18:in `block (3 levels) in <top (required)>'

  2) UserPages profile page 
     Failure/Error: before { visit user_path(user) }
     ActionView::Template::Error:
       undefined method `name' for nil:NilClass
     # ./app/views/users/show.html.erb:1:in `_app_views_users_show_html_erb__369651065_78543920'
     # ./spec/requests/user_pages_spec.rb:18:in `block (3 levels) in <top (required)>'

Finished in 0.68212 seconds
12 examples, 2 failures

The error comes at these two lines

it { should have_selector('h1',    text: user.name) }
it { should have_selector('title', text: user.name) }

Please help me to resolve these errors.

Thanks, Amit Patel

Answer 1

It was typo in $APPLICATION_HOME/app/controllers/users_controller.rb

  def show
    @users = User.find(params[:id])
  end

If you notice, the instance variable name is pluralized (@users) and I have used singular name (@user) in the erb template. That is why it is getting failed.