Question

I am getting unexpected T_TRY, expecting T_FUNCTION error message and am not sure as too why am getting that, can’t we use try and catch block inside class like this:

class Processor
{

    protected $dao;

    protected $fin;

    try
    {
        public function __construct($file)
        {
            //Open File for parsing.
            $this->fin = fopen($file,'w+') or die('Cannot open file');
            // Initialize the Repository DAO.
            $this->dao = new Dao('some name');
        }

        public function initiateInserts()
        {
            while (($data=fgetcsv($this->fin,5000,";"))!==FALSE)
            {
                $initiate_inserts = $this->dao->initiateInserts($data);
            }
        }
        public function initiateCUpdates()
        {
            while (($data=fgetcsv($this->fin,5000,";"))!==FALSE)
            {
                $initiate_updates = $this->dao->initiateCUpdates($data);
            }
        }
        public function initiateExecuteIUpdates()
        {
            while (($data=fgetcsv($this->fin,5000,";"))!==FALSE)
            {
                $initiate_updates = $this->dao->initiateIUpdates($data);
            }
        }
    }
    catch (Exception $e)
    {
    }
}

Answer 1

Don’t try-catch inside of each method, you could simply try-catch when you use your class:

try {
    $p = new Processor($file);
    $p->initiateInserts();
    $p->initiateCUpdates();
    // and so on...
} catch (Exception $e) {
    // handle the error...
}

This way your class will be much cleaner and you can decide what to do with errors. Especially if you use your class in multiple places – you can have customized error handling for each case.