Question

I am having a problem with my code. Whenever i run the program, the last file search would return a zero value where in it shouldn’t.

here is the code:

#include <vector>
#include <string>
#include <windows.h>
#include <stdio.h>
#include <iostream> 
#include <conio.h>

using namespace std;

string GetPath(string path){
        char directory[1024];
        vector <string> filelist;
        strcpy_s(directory,path.c_str());
        BOOL checker;

            WIN32_FIND_DATA findFileData;
            HANDLE hFind = FindFirstFile((LPCSTR)directory, &findFileData);
            cout <<"Files in:" <<"\n"<<directory<<"\n"<<endl;
            checker = FindNextFile(hFind, &findFileData);

            while(checker)
            {
                checker = FindNextFile(hFind, &findFileData);
                filelist.push_back(findFileData.cFileName);//save file list in vector
                cout << findFileData.cFileName << endl;
            }

            DWORD error = GetLastError();
            if( error != ERROR_NO_MORE_FILES)
            {

            }
            /*for (unsigned i=1;i<filelist.size();i++){
                cout << filelist[i]<<endl;//print out the vector
            }*/


            return 0;
}

int main()
{
   string path;
   path="C:\\Program Files\\*.*";
   vector <string> handler;
   path = GetPath(path);
}

Answer 1

Try this as a sanity check:

#include <tchar.h>
#include <stdexcept>
#include <vector>
#include <string>
#include <iostream>
#include <windows.h>

#ifdef UNICODE
typedef std::wstring tstring;
static std::wostream& tcout = std::wcout;
#else
typedef std::string tstring;
static std::ostream& tcout = std::cout;
#endif

std::vector<tstring> GetPath(tstring const& path)
{
    WIN32_FIND_DATA findFileData;
    HANDLE const hFind = FindFirstFile(path.c_str(), &findFileData);
    if (hFind == INVALID_HANDLE_VALUE)
        throw std::runtime_error(""); // realistically, throw something useful

    std::vector<tstring> filelist;
    do filelist.push_back(findFileData.cFileName);
    while (FindNextFile(hFind, &findFileData));
    FindClose(hFind);
    if (GetLastError() != ERROR_NO_MORE_FILES)
        throw std::runtime_error(""); // realistically, throw something useful
    return filelist;
}

int _tmain()
{
    std::vector<tstring> files = GetPath(_T("C:\\Program Files\\*.*"));
    for (std::vector<tstring>::const_iterator iter = files.begin(), iter_end = files.end(); iter != iter_end; ++iter)
        tcout << *iter << _T('\n');
}

If it works, clean up the error handling logic and use it ;-]. If it doesn’t, then @young was correct and you you have localization issues; change your project settings to use Unicode as the character set and it should work.