Question

I am having a small issue with variable assignment. For some reason my line variable doesn’t properly assign.

var records = new Array();
var recid = -5
var subrecid = 6495;
var line = new Array();
line['recid'] = recid;
line['subrecid'] = subrecid;
if (subrecid > 0) records.push(line);

Answer 1

Don’t use an array for non-integer indexing. Use an object. Also, it’s generally better to use [] instead of new Array(). Oh yeah, and there’s a line missing a semicolon.

var records = [];
var recid = -5;
var subrecid = 6495;
var line = {}; // object, not array
line.recid = recid;
line.subrecid = subrecid;
if (subrecid > 0) records.push(line);

Even more concise:

var records = [];
var recid = -5;
var subrecid = 6495;
var line = {
    recid: recid,
    subrecid: subrecid
};
if (subrecid) records.push(line);