Question

I am integrating twitter in my app for sharing a text. My architecture of twitter integration is I have two Button _btnTwitter and _btntwitteLogout and when the user successfully login the twitter his name will display in _btntwitterLogout as title.

When the user tap the _btntwitterLogout it logs out the twitter and logout button hides and login button comes.every thing went ok.but when the user tap the login button(_btnTwitter) the Twitter login popup cmes for login purpose,here is the problem that am facing ,when the popup comes the user tap the cancel button of that popup the popup disappears and here the previous username of the user in the logout button.it didn’t changes. I have put user defaults to check.

-(IBAction)_clickbtnTwitter:(id)sender
{
[[NSUserDefaults standardUserDefaults] setBool:YES forKey:@"Twitter_logged"];
       [_btntwitterLogeout setTitle:nil forState:UIControlStateNormal];
        _btntwitterLogeout.hidden = NO;
        _btnTwitter.hidden=YES;
    if (_engine) return;
    _engine = [[SA_OAuthTwitterEngine alloc] initOAuthWithDelegate: self];
    _engine.consumerKey = kOAuthConsumerKey;
    _engine.consumerSecret = kOAuthConsumerSecret;

    UIViewController *controller = [SA_OAuthTwitterController controllerToEnterCredentialsWithTwitterEngine: _engine delegate: self];

    if (controller) 
        [self presentModalViewController: controller animated: YES];
    else {
        [_engine sendUpdate: [NSString stringWithFormat: @"Already Updated. %@", [NSDate date]]];

    }
}
}

then logout code

-(IBAction)_clickbtntwitterlogeout:(id)sender
{ 

    [[NSUserDefaults standardUserDefaults] setBool:NO forKey:@"Twitter_logged"];
    crosstwitterimage.hidden = YES;
     [_btntwitterLogeout setTitle:nil forState:UIControlStateNormal];
   _btntwitterLogeout.hidden = YES;
    _btnTwitter.hidden=NO;
    _btnTwittermain.enabled = NO;
    [_engine clearAccessToken];
    [_engine clearsCookies];
    [_engine setClearsCookies:YES];
    [[NSUserDefaults standardUserDefaults] removeObjectForKey:@"authData"];
    [[NSUserDefaults standardUserDefaults]removeObjectForKey:@"authName"];
    NSLog(@"%@",[[NSUserDefaults standardUserDefaults]valueForKey:@"authName"]);
    NSLog(@"%@",[[NSUserDefaults standardUserDefaults]valueForKey:@"authData"]);
   [[NSUserDefaults standardUserDefaults] setBool:NO forKey:@"Twitter_logged"];
    [_engine release];
    _engine=nil;   

    NSHTTPCookie *cookie;
    NSHTTPCookieStorage *storage = [NSHTTPCookieStorage sharedHTTPCookieStorage];
    for (cookie in [storage cookies])
    {
        NSString* domainName = [cookie domain];
        NSRange domainRange = [domainName rangeOfString:@"twitter"];
        if(domainRange.length > 0)
        {
            [storage deleteCookie:cookie];

        }
    }

}

in viewwillappear

BOOL logged = [[NSUserDefaults standardUserDefaults] boolForKey:@"Twitter_logged"];
;
if (logged == YES) {
    _btnTwitter. hidden = YES;
    _btntwitterLogeout.hidden = NO;
    crosstwitterimage.hidden = NO;
    _btnTwittermain.enabled =YES;
    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];

    //Checks if there is a saved User Name    
    if([defaults objectForKey:@"kTwitterUserName"])
    {
        NSString *username = [defaults objectForKey:@"kTwitterUserName"];
        [_btntwitterLogeout setTitle:username forState:UIControlStateNormal];
        crosstwitterimage.hidden = NO;
    }
}
    else
    {
        _btnTwitter. hidden = NO;
        crosstwitterimage.hidden = YES;
        [_btntwitterLogeout setTitle:nil forState:UIControlStateNormal];
        _btnTwittermain.enabled =NO;
        crosstwitterimage.hidden = YES;

    }

but when i tap the cancel button in loginwindow of twitter,an comes back the username with the logout button shows ,if the user is already logedout from twitter.
is there any problem in my code.
thanks in advance.

EDIT

#pragma mark SA_OAuthTwitterEngineDelegate
- (void) storeCachedTwitterOAuthData: (NSString *) data forUsername: (NSString *) username {
    NSUserDefaults          *defaults = [NSUserDefaults standardUserDefaults];

    [defaults setObject: data forKey: @"authData"];
    [defaults synchronize];
}

- (NSString *) cachedTwitterOAuthDataForUsername: (NSString *) username {
    return [[NSUserDefaults standardUserDefaults] objectForKey: @"authData"];
}

    #pragma mark SA_OAuthTwitterControllerDelegate
    - (void) OAuthTwitterController: (SA_OAuthTwitterController *) controller authenticatedWithUsername: (NSString *) username {
        NSLog(@"Authenicated for %@", username);
        [_btntwitterLogeout setTitle:username forState:UIControlStateNormal];
        NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
        [defaults setObject:username forKey:@"kTwitterUserName"];
        [defaults synchronize];
        }

    - (void) OAuthTwitterControllerFailed: (SA_OAuthTwitterController *) controller {
        NSLog(@"Authentication Failed!");
    }

    - (void) OAuthTwitterControllerCanceled: (SA_OAuthTwitterController *) controller {
        NSLog(@"Authentication Canceled.");
    }


    #pragma mark TwitterEngineDelegate
    - (void) requestSucceeded: (NSString *) requestIdentifier {
        NSLog(@"Request %@ succeeded", requestIdentifier);
    }

    - (void) requestFailed: (NSString *) requestIdentifier withError: (NSError *) error {
        NSLog(@"Request %@ failed with error: %@", requestIdentifier, error);
    }

Answer 1

Yes there is a problem. Whenever you hit the _btnTwitter, you are setting the Twitter_logged to yes. That’s not correct. You should only set it to yes when there is a successful login. That is when the user has NOT hit cancel on the twitter login window.

In other words, you need to set the Twitter_logged to YES once the user has actually logged in, not when the user clicked on the button _btnTwitter

Seems like SA_OAuthTwitterController has a delegate property pointing to self. You should handle code to set Twitter_logged YES in that delegate method.

Hope that helps.

Edit:

Given the latest code here is where you should add the NsUserDefaults data

  - (void) OAuthTwitterController: (SA_OAuthTwitterController *) controller authenticatedWithUsername: (NSString *) username {
    NSLog(@"Authenicated for %@", username);
    [_btntwitterLogeout setTitle:username forState:UIControlStateNormal];
    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
    [defaults setObject:username forKey:@"kTwitterUserName"];
    [defaults setBool:YES forKey:@"Twitter_logged"]; // Right here - mbh
    [defaults synchronize];
    }