Question

I am just curios as to why Netbeans is throwing an error message at the third from last line, the curly bracket? Thanks for the help.

<?php

   class convert{

var $amnt = htmlspecialchars($_GET["amnt"]);
var $cc_from = htmlspecialchars($_GET["from"]);
var $cc_to = htmlspecialchars($_GET["to"]);

function convert($amnt,$cc_from,$cc_to,$decimals=2){
$db_rate_from = mysql_query("SELECT * FROM $db_tableprefix WHERE country_code='$cc_from'");
$query_row_from = mysql_fetch_array($db_rate_from);
$rate_from = ($query_row_from[rate]);
echo $rate_from;
echo "</br>rate to</br>";

$db_rate_to = mysql_query("SELECT * FROM $db_tableprefix WHERE country_code='$cc_to'");
$query_row_to = mysql_fetch_array($db_rate_to);
$rate_to = ($query_row_to[rate]);
echo $rate_to;
echo "</br>conversion</>";

var $conversion = (number_format(($amnt/$rate_from)*$rate_to,$decimals));
echo $conversion;

}
} 
?>

Answer 1

You can’t declare variables like that in a class. You want something more like this:

class convert
{

    public $amnt;    // don't worry about what public means
    public $cc_from; // if you want to know, have a look at
    public $cc_to;   // http://php.net/public

    // This runs when the class is created with `new convert()`
    public function __construct ()
    {
        $this->amnt = htmlspecialchars($_GET["amnt"]); // sets that $amnt up there
        $this->cc_from = htmlspecialchars($_GET["from"]);
        $this->cc_to = htmlspecialchars($_GET["to"]);
    }

    // All that's changed here is making $amnt into $this->amnt, etc
    function convert($amnt,$cc_from,$cc_to,$decimals=2)
    {
        $db_rate_from = mysql_query("SELECT * FROM $db_tableprefix WHERE country_code='$this->cc_from'");
        $query_row_from = mysql_fetch_array($db_rate_from);
        $rate_from = ($query_row_from[rate]);
        echo $rate_from;
        echo "</br>rate to</br>";

        $db_rate_to = mysql_query("SELECT * FROM $db_tableprefix WHERE country_code='$cc_tothis->'");
        $query_row_to = mysql_fetch_array($db_rate_to);
        $rate_to = ($query_row_to[rate]);
        echo $rate_to;
        echo "</br>conversion</>";

        $conversion = (number_format(($this->amnt / $rate_from) * $rate_to, $decimals));
        echo $conversion;
    }

}