Question

I am just wondering would it be better to do this:

if((fd = open(filename, O_RDWR)) == -1)
{
fprintf(stderr, "open [ %s ]\n", strerror(errno));

return 1;
}

or this

fd = open(filename, O_RDWR);
if(fd == -1)
{
    fprintf(stderr, "open [ %s ]\n", strerror(errno));

    return 1;
}

Many thanks for any suggestions,

Answer 1

Yuck, split it up. What do you gain by mashing it all on one line? Let’s compare and contrast:

Single-line:

• Advantages:
• Disadvantages: Hard to read, prone to error. (Consider your first revision.)

Multi-line:

• Advantages: Easy to read, less error-prone.
• Disadvantages:

I think it’s clear. 🙂

---

“Sometimes putting it on one line makes more sense, for example: while ((c=getchar())!=EOF)“

That’s fine, but that isn’t the case here. There are times when not splitting it up makes more sense, but in general, don’t.

---

“It saves more vertical space”

If one line is killing your ability to see the function, you need to 1) buy a monitor with a resolution higher than 640×480, and 2) Write smaller functions.

Really, I’ve never understood that argument for anything, functions should easily fit on any screen, regardless of a one-line difference.

---

“Multiple lines make it look complex”

Not really, shoving it on one line is arguably harder to read and more complex looking. Splitting things up makes it simpler to process one bit at a time, one shouldn’t assume two lines makes it twice as complex.